Michal
/
Prusa-Firmware-MMU
mirror of https://github.com/prusa3d/Prusa-Firmware-MMU
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Turn off green LED after load/unload finished successfully 

MMU-65
pull/93/head
D.R.racer 2021-08-27 11:27:11 +02:00 committed by DRracer
parent e9e43f744d
commit 06c46b20a6
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/logic/load_filament.cpp
View File

@ -64,7 +64,7 @@ bool LoadFilament::StepInner() {
if (!mi::idler.Engaged()) {
state = ProgressCode::OK;
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::red, ml::off);
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::on);
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::off);
mg::globals.SetFilamentLoaded(true);
}
break;

2
src/logic/unload_filament.cpp
View File

@ -58,7 +58,7 @@ bool UnloadFilament::StepInner() {
state = ProgressCode::OK;
mm::motion.Disable(mm::Pulley);
mg::globals.SetFilamentLoaded(false); // filament unloaded
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::on);
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::off);
}
return false;
case ProgressCode::ERRDisengagingIdler: // couldn't unload to FINDA

2
tests/unit/logic/load_filament/test_load_filament.cpp
View File

@ -73,7 +73,7 @@ void LoadFilamentSuccessful(uint8_t slot, logic::LoadFilament &lf) {
// Stage 4 - disengaging idler
REQUIRE(WhileTopState(lf, ProgressCode::DisengagingIdler, idlerEngageDisengageMaxSteps));
REQUIRE(VerifyState(lf, true, mi::Idler::IdleSlotIndex(), slot, true, ml::on, ml::off, ErrorCode::OK, ProgressCode::OK));
REQUIRE(VerifyState(lf, true, mi::Idler::IdleSlotIndex(), slot, true, ml::off, ml::off, ErrorCode::OK, ProgressCode::OK));
}
TEST_CASE("load_filament::regular_load_to_slot_0-4", "[load_filament]") {

4
tests/unit/logic/unload_filament/test_unload_filament.cpp
View File

@ -94,8 +94,8 @@ void RegularUnloadFromSlot04(uint8_t slot, logic::UnloadFilament &uf) {
// idler should have been disengaged
// no change in selector's position
// FINDA still triggered off
// green LED should be ON
REQUIRE(VerifyState(uf, false, mi::Idler::IdleSlotIndex(), slot, false, ml::on, ml::off, ErrorCode::OK, ProgressCode::OK));
// green LED should be OFF
REQUIRE(VerifyState(uf, false, mi::Idler::IdleSlotIndex(), slot, false, ml::off, ml::off, ErrorCode::OK, ProgressCode::OK));
// Stage 5 - repeated calls to TopLevelState should return "OK"
REQUIRE(uf.TopLevelState() == ProgressCode::OK);