Check for ERRInternal in command_base Step()

Reduces code size significantly

src/logic/command_base.cpp

@@ -136,7 +136,8 @@ bool CommandBase::WaitForModulesErrorRecovery() {
 }
 
 bool CommandBase::Step() {
-    if (WaitForModulesErrorRecovery()) {
+    if (WaitForModulesErrorRecovery() || state == ProgressCode::ERRInternal) {
+        // ERRInternal: firmware panic was triggered
         return true;
     }
     return StepInner();

src/logic/cut_filament.cpp

@@ -100,9 +100,6 @@ bool CutFilament::StepInner() {
         break;
     case ProgressCode::OK:
         return true;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/eject_filament.cpp

@@ -75,9 +75,6 @@ bool EjectFilament::StepInner() {
     case ProgressCode::OK:
         dbg_logic_fP(PSTR("FilamentLoadState after Eject %d"), mg::globals.FilamentLoaded());
         return true;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/home.cpp

@@ -28,9 +28,6 @@ bool Home::StepInner() {
         break;
     case ProgressCode::OK:
         return true;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/hw_sanity.cpp

@@ -168,9 +168,6 @@ bool HWSanity::StepInner() {
         }
     case ProgressCode::OK:
         return true;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/load_filament.cpp

@@ -162,9 +162,6 @@ bool LoadFilament::StepInner() {
             GoToErrDisengagingIdler(ErrorCode::FINDA_DIDNT_SWITCH_ON);
         }
         return false;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/move_selector.cpp

@@ -31,9 +31,6 @@ bool MoveSelector::StepInner() {
         break;
     case ProgressCode::OK:
         return true;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/tool_change.cpp

@@ -179,9 +179,6 @@ bool ToolChange::StepInner() {
             GoToErrDisengagingIdler(ErrorCode::FSENSOR_DIDNT_SWITCH_ON);
         }
         return false;
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;

src/logic/unload_filament.cpp

@@ -159,9 +159,6 @@ bool UnloadFilament::StepInner() {
         break;
     case ProgressCode::OK:
         return true; // successfully finished
-    case ProgressCode::ERRInternal:
-        // firmware panic triggered
-        return true;
     default: // we got into an unhandled state, better report it
         state = ProgressCode::ERRInternal;
         error = ErrorCode::INTERNAL;