From 44408a59c57b5eb02943b995d8e9111ef52062a9 Mon Sep 17 00:00:00 2001
From: gudnimg <gudni.m.g@gmail.com>
Date: Mon, 23 Dec 2024 16:51:39 +0000
Subject: [PATCH] CI: fix an issue with write permissions

Also split the tests into a separate workflow file

Note that the changes won't take effect until this is merged
into main branch.
---
 .github/workflows/build.yml | 71 +----------------------------------
 .github/workflows/tests.yml | 75 +++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+), 70 deletions(-)
 create mode 100644 .github/workflows/tests.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index dfc19ad..fa85872 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -12,6 +12,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+
     steps:
 
     # setup base required dependencies
@@ -71,73 +72,3 @@ jobs:
         draft: true
         files: |
           build/autopublish/*.hex
-
-  tests:
-    runs-on: ubuntu-latest
-
-    permissions:
-      pull-requests: write
-
-    steps:
-
-    # setup base required dependencies
-    - name: Setup dependencies
-      run: |
-          sudo apt-get update
-          sudo apt-get install gcc-11 g++11 lcov cmake ninja-build python3-pyelftools python3-regex python3-polib
-
-    # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-    - name: Checkout ${{ github.event.pull_request.head.ref }}
-      uses: actions/checkout@v4
-      if: ${{ github.event.pull_request }}
-      with:
-        ref: ${{ github.event.pull_request.head.sha }}
-        submodules: true
-
-    - name: Checkout ${{ github.event.ref }}
-      uses: actions/checkout@v4
-      if: ${{ !github.event.pull_request }}
-      with:
-        ref: ${{ github.event.ref }}
-        submodules: true
-
-    - name: Cache Dependencies
-      uses: actions/cache@v4.0.0
-      id: cache-pkgs
-      with:
-          path: ".dependencies"
-          key: "build-deps-1_0_0-linux"
-
-    - name: Setup build dependencies
-      run: |
-          ./utils/bootstrap.py
-
-    - name: Cache permissions
-      run: sudo chmod -R 744 .dependencies
-
-    - name: Build
-      id: tests_run
-      continue-on-error: true
-      run: |
-          mkdir build
-          cd build
-          cmake .. -G Ninja
-          ninja test_coverage_report
-
-
-    - name: Upload artifacts
-      uses: actions/upload-artifact@v4
-      with:
-        name: Coverage
-        path: build/Coverage
-
-    - name: Add PR Comment
-      if: ${{ github.event.pull_request }}
-      uses: mshick/add-pr-comment@v2.8.2
-      with:
-        message-path: build/Summary.txt
-        message-id: "coverage"
-
-    - name: Report failure
-      if: steps.tests_run.outcome == 'failure'
-      run: echo ${{ steps.tests_run.outcome  }} && test -n ""
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
new file mode 100644
index 0000000..97ce21a
--- /dev/null
+++ b/.github/workflows/tests.yml
@@ -0,0 +1,75 @@
+name: tests
+
+on:
+  pull_request_target:
+    branches: [ main, MMU_* ]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+
+    steps:
+
+    # setup base required dependencies
+    - name: Setup dependencies
+      run: |
+          sudo apt-get update
+          sudo apt-get install gcc-11 g++11 lcov cmake ninja-build python3-pyelftools python3-regex python3-polib
+
+    # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+    - name: Checkout ${{ github.event.pull_request.head.ref }}
+      uses: actions/checkout@v4
+      if: ${{ github.event.pull_request }}
+      with:
+        ref: ${{ github.event.pull_request.head.sha }}
+        submodules: true
+
+    - name: Checkout ${{ github.event.ref }}
+      uses: actions/checkout@v4
+      if: ${{ !github.event.pull_request }}
+      with:
+        ref: ${{ github.event.ref }}
+        submodules: true
+
+    - name: Cache Dependencies
+      uses: actions/cache@v4.0.0
+      id: cache-pkgs
+      with:
+          path: ".dependencies"
+          key: "build-deps-1_0_0-linux"
+
+    - name: Setup build dependencies
+      run: |
+          ./utils/bootstrap.py
+
+    - name: Cache permissions
+      run: sudo chmod -R 744 .dependencies
+
+    - name: Build
+      id: tests_run
+      continue-on-error: true
+      run: |
+          mkdir build
+          cd build
+          cmake .. -G Ninja
+          ninja test_coverage_report
+
+
+    - name: Upload artifacts
+      uses: actions/upload-artifact@v3.1.1
+      with:
+        name: Coverage
+        path: build/Coverage
+
+    - name: Add PR Comment
+      if: ${{ github.event.pull_request }}
+      uses: mshick/add-pr-comment@v2.8.2
+      with:
+        message-path: build/Summary.txt
+        message-id: "coverage"
+
+    - name: Report failure
+      if: steps.tests_run.outcome == 'failure'
+      run: echo ${{ steps.tests_run.outcome  }} && test -n ""