From 4a315c920aeafc2606a69a93e67ecf509847a3ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Sun, 30 Apr 2023 19:48:46 +0000 Subject: [PATCH] Remove redundant call to SetPairButOffOthers retract.Reset takes care of setting the green LED to blink. Might as well turn of the red LED during reset just in case. Change in memory: Flash: -30 bytes SRAM: 0 bytes --- src/logic/load_filament.cpp | 1 - src/logic/retract_from_finda.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/logic/load_filament.cpp b/src/logic/load_filament.cpp index 49d0477..d1bc91f 100644 --- a/src/logic/load_filament.cpp +++ b/src/logic/load_filament.cpp @@ -56,7 +56,6 @@ void logic::LoadFilament::Reset2(bool feedPhaseLimited) { } void logic::LoadFilament::GoToRetractingFromFinda() { - ml::leds.SetPairButOffOthers(mg::globals.ActiveSlot(), ml::blink0, ml::off); state = ProgressCode::RetractingFromFinda; error = ErrorCode::RUNNING; retract.Reset(); diff --git a/src/logic/retract_from_finda.cpp b/src/logic/retract_from_finda.cpp index ef1c8dd..35ea348 100644 --- a/src/logic/retract_from_finda.cpp +++ b/src/logic/retract_from_finda.cpp @@ -13,7 +13,7 @@ namespace logic { void RetractFromFinda::Reset() { dbg_logic_P(PSTR("\nRetract from FINDA\n\n")); state = EngagingIdler; - ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::blink0); + ml::leds.SetPairButOffOthers(mg::globals.ActiveSlot(), ml::blink0, ml::off); mi::idler.Engage(mg::globals.ActiveSlot()); }