From b82ffe8db9ad59f9f9eb0ada418da77f3e400709 Mon Sep 17 00:00:00 2001 From: "D.R.racer" Date: Sat, 18 Jun 2022 16:50:44 +0200 Subject: [PATCH] Add missing ResponseParamCode Button support + unit test --- src/modules/protocol.cpp | 1 + tests/unit/modules/protocol/test_protocol.cpp | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/modules/protocol.cpp b/src/modules/protocol.cpp index 7d723cd..da02cae 100644 --- a/src/modules/protocol.cpp +++ b/src/modules/protocol.cpp @@ -138,6 +138,7 @@ DecodeStatus Protocol::DecodeResponse(uint8_t c) { case 'F': case 'A': case 'R': + case 'B': rspState = ResponseStates::ParamValue; responseMsg.paramCode = (ResponseMsgParamCodes)c; responseMsg.paramValue = 0; diff --git a/tests/unit/modules/protocol/test_protocol.cpp b/tests/unit/modules/protocol/test_protocol.cpp index 2333aab..9481338 100644 --- a/tests/unit/modules/protocol/test_protocol.cpp +++ b/tests/unit/modules/protocol/test_protocol.cpp @@ -89,7 +89,7 @@ TEST_CASE("protocol::EncodeResponseCmdAR", "[protocol]") { mp::RequestMsg(mp::RequestMsgCodes::Wait, 0)); - auto responseStatus = GENERATE(mp::ResponseMsgParamCodes::Accepted, mp::ResponseMsgParamCodes::Rejected); + auto responseStatus = GENERATE(mp::ResponseMsgParamCodes::Accepted, mp::ResponseMsgParamCodes::Rejected, mp::ResponseMsgParamCodes::Button); std::array txbuff; uint8_t msglen = mp::Protocol::EncodeResponseCmdAR(requestMsg, responseStatus, txbuff.data()); @@ -347,7 +347,7 @@ TEST_CASE("protocol::DecodeResponseQueryOperation", "[protocol]") { "W0"); const char *status = GENERATE( - "P0", "P1", "E0", "E1", "E9", "F"); + "P0", "P1", "E0", "E1", "E9", "F", "B0", "B1", "B2"); std::string rxbuff(cmdReference); rxbuff += ' ';