c096725674
modules: leds: Implement SetAllOff()
...
A helper function which turns of all LEDs
reduces code size :)
Change in memory:
Flash: -64 bytes
SRAM: 0 bytes
2023-05-02 07:32:27 +02:00
f07e206398
Hold/Resume Idler+Selector even after their homing errors
...
MMU-222
2023-03-14 18:14:02 +01:00
f0a633b4b6
Ignore Idler's SG signal from TMC when rolling over filaments
2023-03-14 17:58:11 +01:00
b97b7561c6
Ignoring the diag pin (stallguard) completely in specified range
...
This seems to greatly improve overall homing reliability of Idler on MMUs which couldn't home with inserted filaments at all.
The only downside is the fact, that we may actually "home" a blocked Idler correctly.
2023-03-14 17:58:11 +01:00
95915cb080
Prototype adaptive Idler homing sg_thrs
...
Needs to be tweaked further to make it a production code.
But my primary concern now is the fact that it doesn't seem to help too much while homing over the too-tightened Idler cover.
2023-03-14 17:58:11 +01:00
98ef2368a0
Rename CurrentVCC->CurrentBandgapVoltage
...
and tune surrounding comments
2023-03-08 15:14:36 +01:00
314233b37f
Add runtime VCC measurement as register
...
- extract logic of undervoltage handling into main.cpp
- fix unit tests
- bump version to 2.1.9 (new register)
2023-03-08 15:14:36 +01:00
23a9978980
VCC undervoltage check module
2023-03-08 15:14:36 +01:00
8b55b25028
Allow cutting current >31
...
Needs reinitialization of the axis (Selector) because the TMC driver needs to set another register to double the current level.
2023-03-07 21:07:52 +01:00
9b43b61939
Idler+Selector homing speeds: writeable registers
2023-03-02 19:54:50 +01:00
d2a2014b89
Cleanup HoldOn-Resume code in movables
2023-03-02 12:20:06 +01:00
ea41fd6b83
Update unit tests
2023-03-02 12:20:06 +01:00
d75119c8d6
Suspend all moves of Idler and Selector when entering an Error screen
2023-03-02 12:20:06 +01:00
7e2375deee
Introduce TMC2130 currents doxy group
...
and clean-up doxygen warnings a bit
2023-02-17 15:50:20 +01:00
88a489e3cb
Add runtime iHold <= iRun check
...
+ refactor TMC register compilation (saves 26B)
+ update currents registers range documentation
+ update currents even in MovableBase::InitMovementNoReinitAxis
2022-12-29 11:27:34 +01:00
425f89c862
Optimization - save 30B
2022-12-29 11:27:34 +01:00
0bca66aeb5
Allow runtime config/register motor/axis iRun current
...
This commit introduces a new set of registers 0x1e, 0x1f and 0x20 which allow reading and writing iRun current values for each axis/motor.
Please note the register contains raw TMC2130 iRun value which needs to be translated into mA to be understandable by people.
Translation table of iRun -> mA is present in tmc2130.cpp for now.
2022-12-29 11:27:34 +01:00
9c9322d02f
Remove old commented code
2022-12-29 09:01:27 +01:00
b16ac63c5d
Compute vSense dynamically from iRun/iHold
2022-12-29 09:01:27 +01:00
7e8ad83e25
Distinguish iRun<32
...
as per suggestion from @leptun
2022-12-28 12:15:47 +01:00
a52f833223
Fix and tune CutFilament + unit tests
...
Several issues addressed in this PR:
- CutFilament tuning + error recovery
- introduce register 0x1d (cut filament selector iRun current level)
- optimize setting iRun and iHold currents in the FW
- CutFilament unit test fixed
2022-12-28 12:15:47 +01:00
b6c3cba396
Refactor CheckFINDAvsEEPROM and setup2
2022-12-27 12:41:29 +01:00
35344f5a5e
If Finda is not pressed, don't report Unload Manually error
2022-12-27 12:41:29 +01:00
4d38d1f620
PFW-1423 add Retry handling in NoCommand for init error
2022-12-27 12:41:29 +01:00
6a4ebdaee6
optimisation: inline functions to reduce size
...
Change in memory:
Flash: -394 bytes
SRAM: 0 bytes
Breakdown:
|------------------------------------------------------------|
| Function name | Flash reduction |
|------------------------------------------| ----------------|
|CommandBase::FinishedOK | 182 bytes |
|MovableBase::InitMovementNoReinitAxis | 60 bytes |
|TMC2130::CheckForErrors | 36 bytes |
|Protocol::UInt16ToHex | 32 bytes |
|AddErrorAxisBit | 24 bytes |
|Application::CheckManualOperation | 22 bytes |
|CommandBase::GoToErrEngagingIdler | 12 bytes |
|Application::PlanCommand | 12 bytes |
|Pulley::FinishHomingAndPlanMoveToParkPos | 8 bytes |
|Pulley::InitAxis | 4 bytes |
|------------------------------------------------------------|
2022-11-19 11:55:46 +01:00
c8c39f7b69
Make sure ToolChange moves Selector to desired slot
...
and verify correct behaviour in unit tests - especially when Selector's start position is at a different slot.
2022-11-18 22:29:01 +01:00
2f6e364ad0
optimisation: compiler should not inline SetFilamentLoaded
...
Change in memory:
Flash: -130 bytes
SRAM: 0 bytes
2022-11-18 21:33:46 +01:00
3f09ba0c16
Unit tests: selector refused to move in ToolChange
...
Revealed all kinds of subtle issues (which is great). All have been fixed in this commit.
2022-11-17 07:32:38 +01:00
299a31b765
Generate exactly 1 userInput event when button pressed (and held)
...
This PR is a different solution to what @gudnimg found in PR#233 / PFW-1404.
The benefit of this approach is the fact, that the button press event is generated when the button is pressed and not after it has been released.
The downside is obvious:
CPUFLASH: +28B
RAM: +1B
2022-11-15 07:19:20 +01:00
0e625dc551
circular_buffer: implement reset()
...
reset() discards any data in the buffer (head == tail)
Change in memory:
Flash: -116 bytes
SRAM: 0 bytes
2022-10-25 07:21:33 +02:00
7bbee87a08
Empty the entire block_index queue when planned moves are aborted
2022-10-22 14:10:31 +00:00
2c6f2d7533
Only set new SGTHRS when planning a Homing move (not regular moves)
2022-10-20 12:09:42 +02:00
dc487c36b6
Remove Enable/Disable TMC when reiniting Movable axes
...
The previous commits by @leptun were correct but there has been one call to Disable axis (and TMC) hidden in `InitMovement`.
Therefore `InitMovement` has been split into 2 separate functions - one is there to allow the original full axis reinit, but the other `InitMovementNoReinitAxis` now only prepares a move without reiniting the TMC driver.
This approach seems to have the benefit of fixing the Idler creep over time.
The disadvantage is the fact, that setting StallGuard threshold is no longer called. We may need to add a special piece of code to handle/apply SGTHRS change at runtime like before.
2022-10-20 12:09:42 +02:00
d77d31b883
Idler dynamic IHOLD adjustments
2022-10-20 12:09:42 +02:00
62a9abc235
Reformat modified files
...
rip history
maybe now?
2022-10-11 07:13:42 +02:00
55e8caa054
Always check for tmc errors
2022-10-11 07:13:42 +02:00
ecb1696a12
Abort moves when tmc errors happen
2022-10-11 07:13:42 +02:00
739f4cd2a3
Check for tmc2130 error flags
2022-10-11 07:13:42 +02:00
9c7701c123
Merge pull request #203 from prusa3d/vintagepc-check-hardware
...
Add module to check for sketchy electronics
2022-09-22 12:17:04 -04:00
1007402b24
Change TIMSK1 atomically in mm::IsrSetEnabled
2022-09-22 17:05:11 +02:00
4f1a301e0e
Force fix formatting
2022-09-22 12:16:41 +02:00
0fa8a3c278
Refactor original solution from @leptun
...
- rename stall*guard to StallGuard (match name with the vendor)
- separate TMC2130 module from EEPROM (they do not need to know about each other at all)
- separate SGTHRS settings from motion - moved to globals like all other "global" parameters
- improved EEPROM storage for SGTHRS
2022-09-22 12:16:41 +02:00
d5249f99fd
Configurable SGTHRS
2022-09-22 12:16:41 +02:00
c5a5304775
Minor cleanup
2022-09-21 18:28:22 -04:00
10fd23700b
Improve implementation
2022-09-16 19:39:27 -04:00
48d5bbc19e
Fix computation of CRC for Write requests (non-zero value2)
2022-09-08 11:39:10 +02:00
9a5a6d9498
Fix computation of CRC
...
came out of unit tests of read/write registers functionality.
2022-09-07 15:44:08 +02:00
5d2a0dab04
Fix selector's homing feedrate
2022-08-18 07:29:51 +02:00
89fc176955
Add basic unit test infrastructure for application + registers
2022-08-11 10:26:42 +02:00
39caece714
Add CRC to the protocol + unit tests
2022-08-11 10:26:42 +02:00
Guðni Már Gilbert
D.R.racer
Alex Voinea
vintagepc
Yuri D'Elia