LoadFilament should not set filament loaded (surprisingly)

because of the change of semantics of LoadFilament operation.
LoadFilament pushes the filament into FINDA and then retracts it back just to keep the
filament ready to be grabbed by the idler and pulley and loaded into the printer's nozzle.

So the selector is not blocked by the filament -> filament NOT loaded
pull/126/head
D.R.racer 2021-09-29 09:08:30 +02:00 committed by DRracer
parent b13214b7f5
commit 5af0125672
3 changed files with 2 additions and 2 deletions

View File

@ -48,6 +48,7 @@ bool FeedToBondtech::Step() {
state = OK;
mm::motion.Disable(mm::Pulley);
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::on);
mg::globals.SetFilamentLoaded(true);
}
return false;
case OK:

View File

@ -71,7 +71,6 @@ bool LoadFilament::StepInner() {
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::red, ml::off);
ml::leds.SetMode(mg::globals.ActiveSlot(), ml::green, ml::on);
mm::motion.Disable(mm::Pulley);
mg::globals.SetFilamentLoaded(true);
}
break;
case ProgressCode::OK:

View File

@ -73,7 +73,7 @@ void LoadFilamentSuccessful(uint8_t slot, logic::LoadFilament &lf) {
// Stage 4 - disengaging idler
REQUIRE(WhileTopState(lf, ProgressCode::DisengagingIdler, idlerEngageDisengageMaxSteps));
REQUIRE(VerifyState(lf, true, mi::Idler::IdleSlotIndex(), slot, false, false, ml::on, ml::off, ErrorCode::OK, ProgressCode::OK));
REQUIRE(VerifyState(lf, false, mi::Idler::IdleSlotIndex(), slot, false, false, ml::on, ml::off, ErrorCode::OK, ProgressCode::OK));
}
TEST_CASE("load_filament::regular_load_to_slot_0-4", "[load_filament]") {